Skip to content

move viewer to JavisViewer#461

Draft
gpucce wants to merge 14 commits into
JuliaAnimators:mainfrom
gpucce:gp-move-viewer
Draft

move viewer to JavisViewer#461
gpucce wants to merge 14 commits into
JuliaAnimators:mainfrom
gpucce:gp-move-viewer

Conversation

@gpucce

@gpucce gpucce commented Jan 22, 2022

Copy link
Copy Markdown
Member

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #460

How did you address these issues with this PR? What methods did you use?
In this PR I remove all parts of Javis that are used for the liveview and will add them in the JavisViewer.jl package.

Once I create a PR in JavisViewer I will reference this one.

@gpucce gpucce marked this pull request as draft January 22, 2022 11:46
@codecov-commenter

codecov-commenter commented Jan 22, 2022 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.42%. Comparing base (0f24fcd) to head (0df92a1).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/Javis.jl 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   96.47%   96.42%   -0.05%     
==========================================
  Files          35       35              
  Lines        1617     1568      -49     
==========================================
- Hits         1560     1512      -48     
+ Misses         57       56       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpucce

gpucce commented Jan 22, 2022

Copy link
Copy Markdown
Member Author

@Wikunia @TheCedarPrince And with a new PR a new interface question.

I am going similar to JavisNB with the equivalent of embed being stream the question is I am moving the liveview=true option into stream and entirely out of render, or at least that would be the plan. Is this a good idea or do you prefer the possibility to call liveview from render itself? Perhaps the best is having it in both render and stream acting in the same way?

Let me know what you think!

@Wikunia

Wikunia commented Jan 22, 2022

Copy link
Copy Markdown
Member

I think I would use a liveview function which works similar to the embed function. No need for a liveviewer keyword anymore. Stream sounds more reasonable to me when we have a stream to twitch functionality or something like that.

@Wikunia Wikunia changed the base branch from master to main February 25, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move liveview outside Javis

3 participants

@gpucce @codecov-commenter @Wikunia